docs: SIWE tutorial #459
Open
docs: SIWE tutorial #459
+389
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
4 times, most recently
from
0c345f4 to
64b3602
Compare
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
from
64b3602 to
ea39756
Compare
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
2 times, most recently
from
ffd51aa to
6538060
Compare
ZigaMr
reviewed
Nov 26, 2024
aefhm
reviewed
Nov 27, 2024
aefhm
reviewed
Nov 28, 2024
aefhm
reviewed
Nov 29, 2024
rube-de
requested changes
Dec 2, 2024
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
from
6538060 to
a581f82
Compare
aefhm
approved these changes
Jan 7, 2025
| @@ -58,15 +63,15 @@ contract SiweAuth is A13e { | |||
| error AddressMismatch(); | |||
| /// The Not before value in the SIWE message is still in the future | |||
| error NotBeforeInFuture(); | |||
| /// The bearer token validity or the Expires value in the SIWE message is in the past | |||
| /// The authentication token validity or the Expires value in the SIWE message is in the past | |||
There was a problem hiding this comment.
Suggested change
| /// The authentication token validity or the Expires value in the SIWE message is in the past | |
| /// Validity of the authentication token or the Expires value in the SIWE message is in the past |
| * 1. The user-facing app calls `login()` which generates the authentication | ||
| * token on-chain. | ||
| * 2. Any smart contract method that requires authentication can take this token | ||
| * as an argument. Passing this token to `authMsgSender()` to verifies it |
There was a problem hiding this comment.
Suggested change
| * as an argument. Passing this token to `authMsgSender()` to verifies it | |
| * as an argument. Passing this token to `authMsgSender()` verifies it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338
PREVIEW
TODO: See if we can better adopt ERC-2771. Replacing
authMsgSender()with_msgSenderis one option. What about appending the token after the calldata? ERC-2771 uses this for transactions, but would this work for the queries too?